fix: use keys when grepping %files_being_mocked in dir()#192
Merged
toddr merged 2 commits intocpanel:masterfrom Feb 12, 2026
Merged
fix: use keys when grepping %files_being_mocked in dir()#192toddr merged 2 commits intocpanel:masterfrom
toddr merged 2 commits intocpanel:masterfrom
Conversation
grep on a hash iterates both keys AND values. Since values are weakrefs to blessed hashrefs, their stringified form could accidentally match the path regex. Using 'keys' ensures only file paths are matched. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
atoomic
approved these changes
Feb 11, 2026
Member
|
I’m disturbed we didn’t find this bug. Could I have a unit test please? That fails if we don’t have this fix |
Contributor
Author
Rebase: fix: use keys when grepping %files_being_mocked in dir()Branch Actions
Automated by Kōan |
toddr
approved these changes
Feb 12, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
grepon%files_being_mockedhash indir()to iterate only keyskeys, grep sees both keys (paths) AND values (weakrefs to blessed hashrefs)Test plan
dir()correctly detects mocked directory contentsSplit from #189 per maintainer request.
🤖 Generated with Claude Code