Conversation
There was a problem hiding this comment.
Pull request overview
Adds Couchbase Server documentation for the /settings/appTelemetry REST API and cross-links it from Prometheus monitoring docs and navigation.
Changes:
- Adds a new REST API reference page for Application Telemetry (
/settings/appTelemetry) with GET/POST examples and parameter descriptions. - Updates Prometheus monitoring docs to mention enabling application telemetry to expose SDK/application metrics.
- Updates shared REST API curl parameter partial and adds the new page to the REST API navigation.
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 8 comments.
| File | Description |
|---|---|
| modules/rest-api/partials/user-pw-host-port-params.adoc | Updates the shared parameter definitions for host/port used by REST API curl examples. |
| modules/rest-api/pages/application-telemetry.adoc | New REST API reference page for application telemetry status and configuration. |
| modules/manage/pages/monitor/set-up-prometheus-for-monitoring.adoc | Adds a section describing how application telemetry affects Prometheus metrics output. |
| modules/ROOT/nav.adoc | Adds the new REST API page to the documentation navigation. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
modules/manage/pages/monitor/set-up-prometheus-for-monitoring.adoc
Outdated
Show resolved
Hide resolved
ingenthr
left a comment
There was a problem hiding this comment.
Nice work on this @ggray-cb . We're getting a number of questions about this functionality, so it'll be great to see it in the docs.
I had a few small comments and @shivaniguptacb may want to review. Also, it looks like copilot caught a few important things (like the kotlin/python ambiguity).
|
Nice work! |
…ements. Also adding the preview config so the preview build will pull in the correct branches.
|
@shivaniguptasf Added default value for the |
|
Adding @RichardSmedley because he expressed interest in reviewing the current draft. Also added @Peter-Searby in hopes he could review the techical details about what happens if a node hits its limit for connected nodes. @ingenthr asked if there was a way for users to tell this has happened. |
ingenthr
left a comment
There was a problem hiding this comment.
Nearly there, thanks! There's one bit of ambiguity I think we should try to address if we can. See comments.
That's basically up to the SDKs to handle. When they attempt to connect to a node that is full, they'll try other nodes, but I can't remember the exact details. Users would presumably see this from the SDK logging, but perhaps @DemetrisChr can confirm? The admins for the cluster would also be able to detect this happening by following the |
| [#get-status] | ||
| == Get Application Telemetry Status | ||
|
|
||
| The following method gets the current status of application telemetry for the cluster. |
There was a problem hiding this comment.
I think you misread my comment here. I meant that "state" sounds like a status, not that that is a better way of referring to it. Settings are definitely not a "status" or a "state" in my mind
Reposting comment because I couldn't un-resolve the original comment, so this might have got missed
This PR adds documentation for the Server
/settings/appTelemetryREST API endpoint.Here's a list of the changes in this PR, with links to a preview. You will need the Docs Team credentials on Confluence to access the preview.
Note: I've made some assumptions about the
maxScrapeClientsPerNodeandscrapeIntervalSecondssettings, so be sure to pay special attention to their descriptions.