fix: remove includeCredentialsOnCrossOriginRequests from generators.yml #324
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
markitosha
approved these changes
Feb 11, 2026
There was a problem hiding this comment.
Pull request overview
This PR implements a global withCredentials configuration mechanism to replace hardcoded per-request settings. The change allows users to configure credential behavior once at the CortiClient level rather than on every API call.
Changes:
- Introduces a global configuration system for
withCredentialsthrough a new utility module - Adds
withCredentialsoption toCortiClientconstructor - Removes hardcoded
withCredentials: truefrom all API endpoint methods across the codebase
Reviewed changes
Copilot reviewed 16 out of 17 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| src/version.ts | Version bump to 0.10.1 |
| src/custom/utils/withCredentialsConfig.ts | New utility module for managing global withCredentials default |
| src/custom/CortiClient.ts | Adds withCredentials option and sets global default when provided |
| src/core/fetcher/Fetcher.ts | Updates fetcher to use global default when per-request value is undefined |
| src/api/resources/transcripts/client/Client.ts | Removes hardcoded withCredentials: true from 5 endpoint methods |
| src/api/resources/templates/client/Client.ts | Removes hardcoded withCredentials: true from 3 endpoint methods |
| src/api/resources/recordings/client/Client.ts | Removes hardcoded withCredentials: true from 4 endpoint methods |
| src/api/resources/interactions/client/Client.ts | Removes hardcoded withCredentials: true from 5 endpoint methods |
| src/api/resources/facts/client/Client.ts | Removes hardcoded withCredentials: true from 6 endpoint methods |
| src/api/resources/documents/client/Client.ts | Removes hardcoded withCredentials: true from 5 endpoint methods |
| src/api/resources/codes/client/Client.ts | Removes hardcoded withCredentials: true from 1 endpoint method |
| src/api/resources/auth/client/Client.ts | Removes hardcoded withCredentials: true from 1 endpoint method |
| src/api/resources/agents/client/Client.ts | Removes hardcoded withCredentials: true from 10 endpoint methods |
| src/Client.ts | Updates SDK version strings from 0.10.0 to 0.10.1 |
| package.json | Updates package version from 0.10.0 to 0.10.1 |
| .fernignore | Adds comment and entry for patched Fetcher.ts file |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a temporary PR created to preview changes from the API specifications.
This PR will be closed when the original API specs PR is merged.
A new, final PR will be created after the API specs changes are merged.
Original PR: https://github.com/corticph/api-specs/pull/128