Fix dspy task 8563: update TOOL_CALL_TEST_CASES in features 2-6 test patches#42
Open
AlienKevin wants to merge 1 commit intocooperbench:mainfrom
Open
Fix dspy task 8563: update TOOL_CALL_TEST_CASES in features 2-6 test patches#42AlienKevin wants to merge 1 commit intocooperbench:mainfrom
AlienKevin wants to merge 1 commit intocooperbench:mainfrom
Conversation
…patches The combined.patch changes ToolCalls.format() return type from list to dict when no metadata is present. Feature 1's test patch correctly updates TOOL_CALL_TEST_CASES and format_from_dict_list assertions, but features 2-6 test patches do not. Since each feature's tests run against the full merged implementation (which includes the format() change), features 2-6 tests fail on the pre-existing test_tool_calls_format_basic[tool_calls_data0-expected0]. Add the same expectation updates (import fix, TOOL_CALL_TEST_CASES dict format, format_from_dict_list assertions) to all 5 remaining feature test patches.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
combined.patchchangesToolCalls.format()return type fromlist[dict]todictwhen no metadata is presentTOOL_CALL_TEST_CASESexpectations andtest_tool_calls_format_from_dict_listassertions to match the new dict formatrunner.sh tests_patch merged.patch), the pre-existingtest_tool_calls_format_basic[tool_calls_data0-expected0]fails whenever features 2–6 tests run — the test still expects the old list format butformat()now returns a dictFix
Add the following updates from feature 1's test patch to features 2–6:
convert_input_schema_to_tool_argsto the import lineTOOL_CALL_TEST_CASESdata update:[{"type": "tool_calls", ...}]→{"tool_calls": [...]}test_tool_calls_format_from_dict_listassertion update:result[0]["tool_calls"]→result["tool_calls"]Test plan