Fix dspy task 8635: change min_instr_chars default from 30 to 0#40
Open
AlienKevin wants to merge 1 commit intocooperbench:mainfrom
Open
Fix dspy task 8635: change min_instr_chars default from 30 to 0#40AlienKevin wants to merge 1 commit intocooperbench:mainfrom
AlienKevin wants to merge 1 commit intocooperbench:mainfrom
Conversation
The combined.patch adds instruction length bounds with min_instr_chars=30. The pre-existing test test_propose_instructions_for_program[None] uses DummyLM which returns "instruction" (11 chars). This falls below the 30-char minimum, causing the code to fall back to the default signature instruction, breaking the assertion. tests2.patch corrects this assertion but tests1.patch does not, so feature 1 tests always fail. Changing the default to 0 preserves backward compatibility while keeping the length-bounds feature functional when explicitly configured.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
combined.patchfor dspy task 8635 adds instruction length bounds toGenerateModuleInstructionandGroundedProposerwithmin_instr_chars=30test_propose_instructions_for_program[None]usesDummyLM({"proposed_instruction": "instruction"})which returns"instruction"(11 chars)"Given the fields 'question', produce the fields 'answer'.")pred_instructions == ["instruction"]then failstests2.patchalready corrects this assertion, buttests1.patchdoes not — so feature 1 tests always fail when run against the combined implementationFix
Change
min_instr_charsdefault from30to0in bothGenerateModuleInstruction.__init__andGroundedProposer.__init__withincombined.patch. The length-bounds feature remains fully functional when explicitly configured, but the default no longer silently rejects short mock/test instructions.Test plan