Conversation
Signed-off-by: Stefan VanBuren <svanburen@buf.build>
Member
Author
|
(I think we can land this and separately do the zstandard thing?) |
i2y
approved these changes
Oct 8, 2025
anuraaga
approved these changes
Oct 9, 2025
Collaborator
anuraaga
left a comment
anuraaga
left a comment
There was a problem hiding this comment.
Thanks @stefanvanburen - I had looked into zstd by default for 3.14 before and was curious how httpx would go
The PR was open at the time but seems to have been rejected. So if we implement our compression interface, it would apply everywhere except for client unary. It probably means we need to either bypass httpx's content encoding altogether or handle the case where we support but but httpx didn't decode it. Just a heads up.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Released yesterday.
Looking at the release notes, it looks like maybe the only thing we may want to get in here is the zstandard support in the stdlib, i.e. drop the dependency for 3.14 and just have support on by default?