Skip to content

Drop setup-python from CI#120

Draft
stefanvanburen wants to merge 2 commits intomainfrom
svanburen/drop-setup-python
Draft

Drop setup-python from CI#120
stefanvanburen wants to merge 2 commits intomainfrom
svanburen/drop-setup-python

Conversation

@stefanvanburen
Copy link
Member

Experimenting with if we need these.

Experimenting with if we need these.

Signed-off-by: Stefan VanBuren <svanburen@buf.build>
This should all be through `uv` now.

Signed-off-by: Stefan VanBuren <svanburen@buf.build>
Copy link
Collaborator

@anuraaga anuraaga left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @stefanvanburen - I think they're technically not needed but then python becomes whatever happens to be on the github runner at the time, which can be different as the runner image gets updated even within the same label.

For a simple source-only wheel, it may be a bit pedantic but I tend to like having explicit setup- actions for all dependencies to still ensure tracking of versions used.

As an aside, I just noticed that GitHub's attestations don't display anything about the runner

https://github.com/connectrpc/connect-python/attestations/17478928

Not sure if it's a display or recording issue, but it seems the workflow is easier to verify for these too.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants