feat!: use cz-conventional-changelog as default adapter

[felipecrs]

• Remove streamich's git-cz from the documentation.
• Use cz-conventional-changelog even when the repository is not commitizen-friendly

Fixes #762.

[dmwelch]

Test errors:

40 passing (8m)
1 pending
2 failing

1. git-cz
   bootstrap
   when config is not provided
   and the config is not returned from configLoader.load
   tells commitizen to use the git strategy:

   AssertionError: expected false to equal true
   + expected - actual

   -false
   +true

   at Context.it (test/tests/cli.js:54:48)

2. git-cz
   bootstrap
   when argv is overridden
   uses the overridden argv:
   TypeError: Cannot read property '0' of undefined
   at Context.it (test/tests/cli.js:62:16)

[felipecrs]

@dmwelch thanks for pointing, there are many things that I'll have to fix. I'll take a look tonight.

[felipecrs]

@dmwelch ready for review 👍🏻

[commitizen-bot]

🎉 This PR is included in version 4.2.2 🎉

The release is available on:

• npm package (@latest dist-tag)
• GitHub release

Your semantic-release bot 📦🚀

[felipecrs]

Ops, it was a breaking change (notice the ! in the feat!:), so a major version bump would be needed. What should we do now? Release a new patch version reverting this commit, and then reapply it ensuring it will produce a new major version?

Perhaps the current semantic-release config does not support the Conventional Commits short ! breaking change identifier.

It was also not included in the changelog.

/cc @dmwelch

[travi]

Release a new patch version reverting this commit, and then reapply it ensuring it will produce a new major version?

that would be my recommendation. please don't unpublish. that just causes more trouble for consumers

Perhaps the current semantic-release config does not support the Conventional Commits short ! breaking change identifier.

since semantic-release uses the angular preset by default, youre right that it does not support this syntax. if you configure it to instead use the conventionalcommits preset, i believe that it should be supported.

i see that you've already opened an issue for switching the default, which i think is at least a worthwhile conversation to have, but currently the angular one is used unless configured specifically.

[dmwelch]

I've manually updated the changelog for v4.2.2 to reflect the inclusion of this commit. I was going to revert the changes now, but I'm not very familiar with the semantic-release package so I'm going to hold off and get up to speed first (unless someone else wants to beat me to the punch...).

[felipecrs]

So the plan I suggest is:

• 1. Revert feat!: use cz-conventional-changelog as default adapter #778 using fix: as the commit type - this should trigger a new patch -> fix: revert "use cz-conventional-changelog as default adapter (#778)" #792
• 2. Add the preset conventionalcommits to semantic-release configuration -> chore(release): use conventionalcommits preset in semantic-release #793
• 3. Wait for the patch release to happen, then reapply this PR -> feat: use cz-conventional-changelog as default adapter #794

Please merge in the order.

/cc @dmwelch

[felipecrs]

@jimthedev @dmwelch in case you guys don't have time (I'm not sure who else is maintaining this project), I can help to maintain this repo.