feat: add version parameter to install scripts by zeroshade · Pull Request #323 · columnar-tech/dbc

zeroshade · 2026-02-23T18:26:48Z

Summary

Adds version parameter support to both Windows and Unix install scripts, allowing users to install specific versions of dbc instead of always defaulting to 'latest'.

Changes

Windows PowerShell Script (`scripts/install.ps1`)

Added -Version parameter to specify version (e.g., 0.2.0, v0.2.0, or latest)
Automatic normalization strips 'v'/'V' prefix from version strings
Defaults to 'latest' for backward compatibility
Updated script help documentation

Bash Script (`scripts/install.sh`)

Added --version parameter to specify version (long form only to avoid conflict with -v verbose flag)
Automatic normalization strips 'v'/'V' prefix from version strings
Version format validation (semantic version or 'latest')
Rejects empty/invalid versions with helpful error messages
Defaults to 'latest' for backward compatibility
Updated help documentation with examples
POSIX shell compliant

Documentation

Added version parameter examples to docs/getting_started/installation.md
Added version parameter examples to README.md
Shows download-then-run approach for Windows version-specific installs

Usage Examples

Windows:

# Default (latest)
.\install.ps1

# Specific version
.\install.ps1 -Version "0.2.0"

# With v prefix
.\install.ps1 -Version "v0.2.0"

Linux/macOS:

# Default (latest)
./install.sh

# Specific version
./install.sh --version 0.2.0

# With v prefix
./install.sh --version v0.2.0

Testing

✅ Backward compatibility maintained (defaults to 'latest')
✅ Version normalization works across all formats
✅ Windows script help displays correctly
✅ Bash script version validation works
✅ POSIX shell compliance verified
✅ Documentation examples are accurate

Commits

feat: add -Version parameter to Windows install script
docs: add examples for version parameter in Windows install
feat: add APP_VERSION environment variable support
refactor: remove APP_VERSION env var, keep only -Version param
feat: add --version parameter to bash install script
fix: improve version parameter validation and quoting
fix: correct empty version string validation logic

Allow users to specify which version to install via -Version parameter. Accepts semantic versions with or without 'v' prefix, or 'latest'. Defaults to 'latest' for backward compatibility.

Check APP_VERSION environment variable as fallback before defaulting to 'latest'. Priority: -Version parameter > APP_VERSION env var > 'latest'.

Simplify version handling by accepting only the -Version parameter. Removed APP_VERSION environment variable fallback for clarity.

Allow users to specify which version to install via --version parameter. Accepts semantic versions with or without 'v' prefix, or 'latest'. Defaults to 'latest' for backward compatibility.

- Add version format validation (semantic version or 'latest') - Fix variable quoting in test conditions - Reject empty version strings with helpful error - Combine version processing into single block

Replace contradictory nested conditions with single check that properly rejects both missing and empty version arguments.

amoeba

The idea makes sense but I'm not sure what the rationale is. And I'm not sure we want to advertise that users install non-latest versions of dbc ever.

zeroshade · 2026-02-23T21:26:30Z

It's needed for consistency with a github action. Users need to be able to pin installing a specific version, even from these scripts. (this functionality would already be available via uv/pip install etc. which could pin a specific version of the CLI to install)

amoeba

In that case, I think it'd be better to not mention this in the README or docs. Also left one note.

scripts/install.sh

Co-authored-by: Bryce Mecum <petridish@gmail.com>

zeroshade · 2026-02-23T22:58:05Z

@amoeba i've removed the changes to the docs as requested.

scripts/install.sh

amoeba · 2026-02-23T23:33:47Z

I think it's minor since this isn't exposed to users now but I get this error which could confuse people if they use the setup-dbc action:

$ sh scripts/install.sh --version 0.1.1
Downloading dbc (0.1.1) for aarch64-apple-darwin
Error: dbc is not available for your platform. Please create an issue at https://github.com/columnar-tech/dbc/issues or contact support@columnar.tech for assistance.

Co-authored-by: Bryce Mecum <petridish@gmail.com>

zeroshade · 2026-02-24T00:27:49Z

ah, change the error to specify there's no matching version for the platform instead?

zeroshade · 2026-02-24T00:31:04Z

Have any suggested wording to use instead @amoeba ?

amoeba · 2026-02-24T00:39:51Z

Yeah, error saying the version requested isn't a valid version to request. I can imagine someone putting the wrong version in their action and erroring about platforms might sense them off on wild goose chase.

I think it's hard for us to have separate error detection for version and also platform. At least without changing things on the AWS side. So could we just update the existing error to say,

Error: dbc {version} is either not available or not available for your platform. Double-check the version you've requested. Please file an issue at https://github.com/columnar-tech/dbc/issues or contact support@columnar.tech for assistance.

zeroshade · 2026-02-24T16:02:37Z

@amoeba updated the error message string

amoeba

LGTM, thanks!

zeroshade added 7 commits February 23, 2026 12:50

feat: add -Version parameter to Windows install script

4ba4019

Allow users to specify which version to install via -Version parameter. Accepts semantic versions with or without 'v' prefix, or 'latest'. Defaults to 'latest' for backward compatibility.

docs: add examples for version parameter in Windows install

6fcc306

feat: add APP_VERSION environment variable support

5082e0a

Check APP_VERSION environment variable as fallback before defaulting to 'latest'. Priority: -Version parameter > APP_VERSION env var > 'latest'.

refactor: remove APP_VERSION env var, keep only -Version param

e1ee03c

Simplify version handling by accepting only the -Version parameter. Removed APP_VERSION environment variable fallback for clarity.

feat: add --version parameter to bash install script

4d611bf

Allow users to specify which version to install via --version parameter. Accepts semantic versions with or without 'v' prefix, or 'latest'. Defaults to 'latest' for backward compatibility.

fix: improve version parameter validation and quoting

4b26d8e

- Add version format validation (semantic version or 'latest') - Fix variable quoting in test conditions - Reject empty version strings with helpful error - Combine version processing into single block

fix: correct empty version string validation logic

995414f

Replace contradictory nested conditions with single check that properly rejects both missing and empty version arguments.

zeroshade temporarily deployed to snapshot February 23, 2026 18:26 — with GitHub Actions Inactive

zeroshade requested review from amoeba, ianmcook and kentkwu February 23, 2026 18:27

amoeba reviewed Feb 23, 2026

View reviewed changes

scripts/install.sh Outdated Show resolved Hide resolved

Update scripts/install.sh

2279271

Co-authored-by: Bryce Mecum <petridish@gmail.com>

zeroshade temporarily deployed to snapshot February 23, 2026 22:49 — with GitHub Actions Inactive

remove -Version from the docs

17b0f20

zeroshade temporarily deployed to snapshot February 23, 2026 22:57 — with GitHub Actions Inactive

amoeba requested changes Feb 23, 2026

View reviewed changes

scripts/install.sh Outdated Show resolved Hide resolved

Update scripts/install.sh

a61ca47

Co-authored-by: Bryce Mecum <petridish@gmail.com>

zeroshade temporarily deployed to snapshot February 24, 2026 00:26 — with GitHub Actions Inactive

improve error message

a10faf4

zeroshade deployed to snapshot February 24, 2026 16:02 — with GitHub Actions Active

zeroshade requested a review from amoeba February 24, 2026 16:27

amoeba approved these changes Feb 24, 2026

View reviewed changes

zeroshade merged commit 6cd6e28 into main Feb 25, 2026
4 checks passed

zeroshade deleted the feat/windows-install-version-param branch February 25, 2026 16:37

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat: add version parameter to install scripts#323

feat: add version parameter to install scripts#323
zeroshade merged 11 commits intomainfrom
feat/windows-install-version-param

zeroshade commented Feb 23, 2026 •

edited

Loading

Uh oh!

amoeba left a comment

Uh oh!

zeroshade commented Feb 23, 2026

Uh oh!

amoeba left a comment

Uh oh!

Uh oh!

zeroshade commented Feb 23, 2026

Uh oh!

Uh oh!

amoeba commented Feb 23, 2026

Uh oh!

zeroshade commented Feb 24, 2026

Uh oh!

zeroshade commented Feb 24, 2026

Uh oh!

amoeba commented Feb 24, 2026

Uh oh!

zeroshade commented Feb 24, 2026

Uh oh!

amoeba left a comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Conversation

zeroshade commented Feb 23, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary

Changes

Windows PowerShell Script (scripts/install.ps1)

Bash Script (scripts/install.sh)

Documentation

Usage Examples

Testing

Commits

Uh oh!

amoeba left a comment

Choose a reason for hiding this comment

Uh oh!

zeroshade commented Feb 23, 2026

Uh oh!

amoeba left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

zeroshade commented Feb 23, 2026

Uh oh!

Uh oh!

amoeba commented Feb 23, 2026

Uh oh!

zeroshade commented Feb 24, 2026

Uh oh!

zeroshade commented Feb 24, 2026

Uh oh!

amoeba commented Feb 24, 2026

Uh oh!

zeroshade commented Feb 24, 2026

Uh oh!

amoeba left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

zeroshade commented Feb 23, 2026 •

edited

Loading

Windows PowerShell Script (`scripts/install.ps1`)

Bash Script (`scripts/install.sh`)