Reworking how committee pronouns and names are arranged#117
Open
Games4Doritos wants to merge 1 commit intomainfrom
Open
Reworking how committee pronouns and names are arranged#117Games4Doritos wants to merge 1 commit intomainfrom
Games4Doritos wants to merge 1 commit intomainfrom
Conversation
-Rather than name and pronouns being part of the same rectangle, they are their own independent blocks that will wrap if appropriate - Added placeholder text for committee portrait pronouns, where it will say "No Pronouns" if the pronouns attribute is blank. We can definitely change if needed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Change Summary
I'll try explain the problem:
Having average-sized names and pronouns on committee portraits fit how it looks on the figma, but with long enough names and pronouns, it starts to act weird:
It's alright if the name is long enough, but it still feels weird to me at least as the background fills the full surrounding rectangle and so leaves unwanted empty space.
Changes present in this pr hopefully solve this by having the name and pronouns separate be inline-blocks, so each committee portrait will have the name and pronouns arranged to look like the figma if the length of text is small enough, otherwise the pronouns will go to the next line
The name will wrap to the next line of it's container if long enough and still fill it's box, but I don't know if that's an issue in itself.
Change Form
Other Information
Related issue