Skip to content

Ensure Sheets render above native peers by enabling lightweight mode and adding blocker #4504

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
shai-almog wants to merge 3 commits into from
+11 −1
Closed

Ensure Sheets render above native peers by enabling lightweight mode and adding blocker #4504

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
fbd471e
Hide native peers while sheets are visible
shai-almog Feb 8, 2026
44ae4d5
Capture screenshot for sheets over native peers
shai-almog Feb 8, 2026
0d26f1e
Delay sheet display in browser test
shai-almog Feb 8, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 11 additions & 1 deletion .../java/com/codenameone/examples/hellocodenameone/tests/BrowserComponentScreenshotTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,7 @@

import com.codename1.ui.BrowserComponent;
import com.codename1.ui.Form;
import com.codename1.ui.Sheet;
import com.codename1.ui.layouts.BorderLayout;
import com.codename1.ui.util.UITimer;
import com.codename1.util.SuccessCallback;
Expand All @@ -13,6 +14,7 @@ public class BrowserComponentScreenshotTest extends BaseTest {
private Form form;
private boolean jsReady;
private boolean jsCheckPending;
private boolean sheetShown;

@Override
public boolean runTest() throws Exception {
Expand Down Expand Up @@ -56,8 +58,16 @@ public void onSucess(BrowserComponent.JSRef result) {
return;
}

UITimer.timer(2000, false, form, readyRunnable);
Runnable run = readyRunnable;
readyRunnable = null;
UITimer.timer(300, false, form, () -> {
if (!sheetShown) {
sheetShown = true;
Sheet sheet = new Sheet(null, "Browser Sheet");
sheet.show(0);
}
UITimer.timer(700, false, form, run);
});
}

private static String buildHtml() {
Expand Down
Loading