Add unit tests for RequestBuilder listeners, Display EDT exception, BrowserWindow fallback, and Purchase sync#4503
Merged
shai-almog merged 2 commits intomasterfrom Feb 8, 2026
Conversation
✅ Continuous Quality ReportTest & Coverage
Static Analysis
Generated automatically by the PR CI workflow. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Description
RequestBuilderActionListenerTestwhich exercises async/sync JSON map callbacks, properties→business object parsing (fetchAsProperties/fetchAsPropertyList), and the legacy asyncCallbackpaths for bytes and strings to hitGetAsBytesAsyncImplActionListenerandGetAsStringAsyncImplActionListener.SampleItemtest business object used by the properties tests (implementsPropertyBusinessObject).DisplayTestwithtestEdtExceptionCapturedByCrashReporterto enable async stack traces and verifyDisplay$EdtExceptionpropagation to aCrashReport.BrowserWindowTestwithfallbackWindowUsesBrowserFormto exercise theBrowserWindow.BrowserFormfallback code path when native windows are not available.PurchaseTestwithtestSynchronizeReceiptsSyncWaitsForAsyncFetchto exercise theSynchronizeReceiptsSyncRunnable/ async receipt fetch path used bysynchronizeReceiptsSync.CSSBorder.LinearGradientcould not be reached via public APIs without reflection, so no direct test was added for it.Testing
maven/core-unittests.cd maven && mvn -pl core-unittests -am -DunitTests=true -Dmaven.javadoc.skip=true -Plocal-dev-javase test.cd maven && mvn clean verify -DunitTests=true -pl core-unittests -am -Dmaven.javadoc.skip=true -Plocal-dev-javase../scripts/fast-core-unit-smoke.sh.Codex Task