Fixes for DM_DEFAULT_ENCODING spotbugs warnings

[shai-almog]

No description provided.

[github-actions]

✅ ByteCodeTranslator Quality Report

Test & Coverage

• ✅ Tests: 146 total, 0 failed, 2 skipped

Benchmark Results

• Execution Time: 10272 ms

• Hotspots (Top 20 sampled methods):

  • 22.18% java.lang.String.indexOf (405 samples)
  • 17.31% com.codename1.tools.translator.Parser.isMethodUsed (316 samples)
  • 15.83% com.codename1.tools.translator.Parser.addToConstantPool (289 samples)
  • 10.62% java.util.ArrayList.indexOf (194 samples)
  • 4.44% java.lang.Object.hashCode (81 samples)
  • 3.50% com.codename1.tools.translator.ByteCodeClass.calcUsedByNative (64 samples)
  • 2.52% java.lang.System.identityHashCode (46 samples)
  • 2.46% com.codename1.tools.translator.ByteCodeClass.fillVirtualMethodTable (45 samples)
  • 1.15% com.codename1.tools.translator.BytecodeMethod.optimize (21 samples)
  • 1.10% java.lang.Integer.getChars (20 samples)
  • 1.04% com.codename1.tools.translator.BytecodeMethod.appendCMethodPrefix (19 samples)
  • 1.04% java.lang.StringCoding.encode (19 samples)
  • 0.93% com.codename1.tools.translator.ByteCodeClass.markDependent (17 samples)
  • 0.88% java.lang.StringBuilder.append (16 samples)
  • 0.82% sun.nio.ch.FileDispatcherImpl.write0 (15 samples)
  • 0.77% sun.nio.fs.UnixNativeDispatcher.open0 (14 samples)
  • 0.71% com.codename1.tools.translator.Parser.generateClassAndMethodIndexHeader (13 samples)
  • 0.60% com.codename1.tools.translator.Parser.cullMethods (11 samples)
  • 0.60% java.io.UnixFileSystem.getBooleanAttributes0 (11 samples)
  • 0.55% com.codename1.tools.translator.BytecodeMethod.addToConstantPool (10 samples)

• ⚠️ Coverage report not generated.

Static Analysis

• ✅ SpotBugs: no findings (report was not generated by the build).
• ⚠️ PMD report not generated.
• ⚠️ Checkstyle report not generated.

Generated automatically by the PR CI workflow.

[github-actions]

✅ Continuous Quality Report

Test & Coverage

• ✅ Tests: 2292 total, 0 failed, 0 skipped
• 📊 Line coverage: 52.80% [HTML preview] [Download]
  • Lowest covered classes
    • com.codename1.io.rest.RequestBuilder$FetchAsPropertyListActionListener – 0.00%
    • com.codename1.io.rest.RequestBuilder$FetchAsPropertiesActionListener – 0.00%
    • com.codename1.ui.Display$EdtException – 0.00%
    • com.codename1.ui.BrowserWindow$BrowserForm – 0.00%
    • com.codename1.ui.plaf.CSSBorder$LinearGradient – 0.00%
    • com.codename1.io.rest.RequestBuilder$GetAsStringAsyncImplActionListener – 0.00%
    • com.codename1.io.rest.RequestBuilder$GetAsJsonMapActionListener – 0.00%
    • com.codename1.payment.Purchase$SynchronizeReceiptsSyncRunnable – 0.00%
    • com.codename1.io.rest.RequestBuilder$GetAsBytesAsyncImplActionListener – 0.00%
    • com.codename1.io.rest.RequestBuilder$FetchAsJsonMapActionListener – 0.00%

Static Analysis

• SpotBugs [HTML preview] [Download]
  • ❌ ByteCodeTranslator: 97 findings (High: 2, Normal: 68, Low: 27)
    • Top findings
      • High: com/codename1/tools/translator/BytecodeMethod.java:559 – Method com.codename1.tools.translator.BytecodeMethod.findWritableFields(Set) seems to be useless (rule: UC_USELESS_VOID_METHOD)
      • High: com/codename1/tools/translator/bytecodes/TryCatch.java:75 – Write to static field com.codename1.tools.translator.bytecodes.TryCatch.hasTryCatch from instance method com.codename1.tools.translator.bytecodes.TryCatch.appendInstruction(StringBuilder, List) (rule: ST_WRITE_TO_STATIC_FROM_INSTANCE_METHOD)
      • Normal: com/codename1/tools/translator/ByteCodeClass.java:1791 – com.codename1.tools.translator.ByteCodeClass.getBaseClassObject() may expose internal representation by returning ByteCodeClass.baseClassObject (rule: EI_EXPOSE_REP)
      • …and 94 more
  • ❌ android: 412 findings (High: 24, Normal: 196, Low: 192)
    • Top findings
      • High: CodenameOne/src/com/codename1/impl/CodenameOneThread.java:48 – com.codename1.impl.CodenameOneThread.STACK_FRAME_SIZE isn't final but should be (rule: MS_SHOULD_BE_FINAL)
      • High: com/codename1/impl/android/AndroidImplementation.java:1066 – Write to static field com.codename1.impl.android.AndroidImplementation.context from instance method com.codename1.impl.android.AndroidImplementation.setContext(Context) (rule: ST_WRITE_TO_STATIC_FROM_INSTANCE_METHOD)
      • High: com/codename1/impl/android/AndroidImplementation.java:1267 – com.codename1.impl.android.AndroidImplementation.isDarkMode() has Boolean return type and returns explicit null (rule: NP_BOOLEAN_RETURN_NULL)
      • …and 409 more
  • ❌ codenameone-maven-plugin: 480 findings (High: 1, Normal: 316, Low: 163)
    • Top findings
      • High: com/codename1/maven/AbstractCN1Mojo.java:807 – com.codename1.maven.AbstractCN1Mojo.OS isn't final but should be (rule: MS_SHOULD_BE_FINAL)
      • Normal: com/codename1/builders/AndroidGradleBuilder.java:1018 – Dead store to googleServicesJson in com.codename1.builders.AndroidGradleBuilder.build(File, BuildRequest) (rule: DLS_DEAD_LOCAL_STORE)
      • Normal: com/codename1/builders/AndroidGradleBuilder.java:1043 – Possible null pointer dereference in com.codename1.builders.AndroidGradleBuilder.build(File, BuildRequest) due to return value of called method (rule: NP_NULL_ON_SOME_PATH_FROM_RETURN_VALUE)
      • …and 477 more
  • ✅ core-unittests: 0 findings (no issues)
  • ❌ ios: 125 findings (High: 4, Normal: 75, Low: 46)
    • Top findings
      • High: com/codename1/impl/ios/IOSImplementation.java:1218 – com.codename1.impl.ios.IOSImplementation.isDarkMode() has Boolean return type and returns explicit null (rule: NP_BOOLEAN_RETURN_NULL)
      • High: com/codename1/impl/ios/IOSImplementation.java:127 – com.codename1.impl.ios.IOSImplementation.nativeInstance isn't final but should be (rule: MS_SHOULD_BE_FINAL)
      • High: com/codename1/impl/ios/IOSImplementation.java:212 – Write to static field com.codename1.impl.ios.IOSImplementation.instance from instance method com.codename1.impl.ios.IOSImplementation.init(Object) (rule: ST_WRITE_TO_STATIC_FROM_INSTANCE_METHOD)
      • …and 122 more
• ✅ PMD: 0 findings (no issues) [Report archive]
• ✅ Checkstyle: 0 findings (no issues) [Report archive]

Generated automatically by the PR CI workflow.

[shai-almog]

Compared 30 screenshots: 30 matched.

Native Android coverage

• 📊 Line coverage: 7.14% (3622/50707 lines covered) [HTML preview] (artifact android-coverage-report, jacocoAndroidReport/html/index.html)
  • Other counters: instruction 5.57% (17791/319371), branch 2.71% (842/31061), complexity 3.31% (983/29686), method 5.83% (806/13824), class 9.53% (174/1825)
  • Lowest covered classes
    • kotlin.collections.kotlin.collections.ArraysKt___ArraysKt – 0.00% (0/6327 lines covered)
    • kotlin.collections.unsigned.kotlin.collections.unsigned.UArraysKt___UArraysKt – 0.00% (0/2384 lines covered)
    • org.jacoco.agent.rt.internal_b6258fc.asm.org.jacoco.agent.rt.internal_b6258fc.asm.ClassReader – 0.00% (0/1519 lines covered)
    • kotlin.collections.kotlin.collections.CollectionsKt___CollectionsKt – 0.00% (0/1148 lines covered)
    • org.jacoco.agent.rt.internal_b6258fc.asm.org.jacoco.agent.rt.internal_b6258fc.asm.MethodWriter – 0.00% (0/923 lines covered)
    • kotlin.sequences.kotlin.sequences.SequencesKt___SequencesKt – 0.00% (0/712 lines covered)
    • kotlin.text.kotlin.text.StringsKt___StringsKt – 0.00% (0/623 lines covered)
    • org.jacoco.agent.rt.internal_b6258fc.asm.org.jacoco.agent.rt.internal_b6258fc.asm.Frame – 0.00% (0/564 lines covered)
    • kotlin.collections.kotlin.collections.ArraysKt___ArraysJvmKt – 0.00% (0/495 lines covered)
    • kotlinx.coroutines.kotlinx.coroutines.JobSupport – 0.00% (0/423 lines covered)

✅ Native Android screenshot tests passed.

Native Android coverage

• 📊 Line coverage: 7.14% (3622/50707 lines covered) [HTML preview] (artifact android-coverage-report, jacocoAndroidReport/html/index.html)
  • Other counters: instruction 5.57% (17791/319371), branch 2.71% (842/31061), complexity 3.31% (983/29686), method 5.83% (806/13824), class 9.53% (174/1825)
  • Lowest covered classes
    • kotlin.collections.kotlin.collections.ArraysKt___ArraysKt – 0.00% (0/6327 lines covered)
    • kotlin.collections.unsigned.kotlin.collections.unsigned.UArraysKt___UArraysKt – 0.00% (0/2384 lines covered)
    • org.jacoco.agent.rt.internal_b6258fc.asm.org.jacoco.agent.rt.internal_b6258fc.asm.ClassReader – 0.00% (0/1519 lines covered)
    • kotlin.collections.kotlin.collections.CollectionsKt___CollectionsKt – 0.00% (0/1148 lines covered)
    • org.jacoco.agent.rt.internal_b6258fc.asm.org.jacoco.agent.rt.internal_b6258fc.asm.MethodWriter – 0.00% (0/923 lines covered)
    • kotlin.sequences.kotlin.sequences.SequencesKt___SequencesKt – 0.00% (0/712 lines covered)
    • kotlin.text.kotlin.text.StringsKt___StringsKt – 0.00% (0/623 lines covered)
    • org.jacoco.agent.rt.internal_b6258fc.asm.org.jacoco.agent.rt.internal_b6258fc.asm.Frame – 0.00% (0/564 lines covered)
    • kotlin.collections.kotlin.collections.ArraysKt___ArraysJvmKt – 0.00% (0/495 lines covered)
    • kotlinx.coroutines.kotlinx.coroutines.JobSupport – 0.00% (0/423 lines covered)

[shai-almog]

Compared 30 screenshots: 30 matched.
✅ Native Android screenshot tests passed.

Benchmark Results

• VM Translation Time: 289 seconds
• Compilation Time: 261 seconds

Detailed Performance Metrics

Metric	Duration
Build Time Statistics
Setup & Unzip	25915 ms
Extract Extensions	21 ms
Google Services Setup	3 ms
Scan Classes	551 ms
Extract Libs	1007 ms
Inject Build Hints	29 ms
Generate Unit Tests	2 ms
Generate Stubs	841 ms
Compile Stubs	1927 ms
Generate Icons	808 ms
Prepare ParparVM	191 ms
ParparVM Execution	168427 ms
Post-VM Setup	174 ms
CocoaPods	5023 ms
Finalize	30 ms
Total Time	204950 msMaven Overhead : 85000 ms
CocoaPods Install (Script)	1000 ms
Simulator Boot	183000 ms
Simulator Boot (Run)	2000 ms
App Install	58000 ms
App Launch	20000 ms
Test Execution	165000 ms