Skip to content

Drop FlowValidator#117

Merged
raphael-goetz merged 3 commits intomainfrom
116-drop-flow-validator
Feb 26, 2026
Merged

Drop FlowValidator#117
raphael-goetz merged 3 commits intomainfrom
116-drop-flow-validator

Conversation

@raphael-goetz
Copy link
Member

Resolves: #116

Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR removes the flow_validator feature and module from the code0-flow library, as it is being replaced by a TypeScript script implementation (per issue #116). The removal is clean and complete, eliminating all associated code and updating the feature configuration appropriately.

Changes:

  • Removed the flow_validator module and all its submodules (rule validation logic, violation types, and tests)
  • Removed flow_validator feature from Cargo.toml and updated the all feature accordingly
  • Updated the tucana dependency from version 0.0.52 to 0.0.54

Reviewed changes

Copilot reviewed 10 out of 11 changed files in this pull request and generated no comments.

Show a summary per file
File Description
src/lib.rs Removed conditional compilation directive for flow_validator module
src/flow_validator/mod.rs Deleted main flow validator module with flow verification logic
src/flow_validator/rule/mod.rs Deleted rule module declarations
src/flow_validator/rule/violation.rs Deleted violation types and error formatting logic
src/flow_validator/rule/regex.rs Deleted regex pattern validation implementation and tests
src/flow_validator/rule/number_range.rs Deleted number range validation implementation and tests
src/flow_validator/rule/item_of_collection.rs Deleted collection membership validation implementation and tests
src/flow_validator/rule/contains_type.rs Deleted type containment validation implementation
src/flow_validator/rule/contains_key.rs Deleted key presence validation implementation
Cargo.toml Removed flow_validator feature and updated tucana dependency version
Cargo.lock Updated lock file with new dependency versions and checksums

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@raphael-goetz raphael-goetz merged commit 4a7c9e1 into main Feb 26, 2026
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Drop FlowValidator

2 participants