Merged
Conversation
raphael-goetz
changed the title
GitLab Pipeline ActionGeneral informationLink to pipeline: https://gitlab.com/code0-tech/development/aquila/-/pipelines/2346421447 Status: Passed |
Contributor
There was a problem hiding this comment.
Pull request overview
This PR adds RuntimeStatusService to enable runtime status updates in the Aquila gRPC server. The implementation follows the established pattern used by other services (DataType, FlowType, RuntimeFunction) by creating a server implementation that forwards requests to a Sagittarius client, which then communicates with the backend service.
Changes:
- Added
SagittariusRuntimeStatusServiceClientfor handling runtime status update requests to Sagittarius - Added
AquilaRuntimeStatusServiceServerto receive runtime status updates from clients - Integrated RuntimeStatusService into the gRPC server in both health service and non-health service configurations
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 4 comments.
| File | Description |
|---|---|
| src/sagittarius/runtime_status_service_client_impl.rs | New client implementation for forwarding runtime status updates to Sagittarius with proper status enum transformation |
| src/sagittarius/mod.rs | Added module declaration for runtime_status_service_client_impl |
| src/server/runtime_status_service_server_impl.rs | New server implementation for receiving runtime status updates and delegating to the Sagittarius client |
| src/server/mod.rs | Integrated RuntimeStatusService into the gRPC server setup and registered it in both server configurations |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> Signed-off-by: Raphael Götz <52959657+raphael-goetz@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves: #224