Skip to content

Reuse installed ginkgo and use cleaner binary check#891

Merged
chombium merged 1 commit intocloudfoundry:mainfrom
jorbaum:minor-test-script-improvements
Mar 2, 2026
Merged

Reuse installed ginkgo and use cleaner binary check#891
chombium merged 1 commit intocloudfoundry:mainfrom
jorbaum:minor-test-script-improvements

Conversation

@jorbaum
Copy link
Contributor

@jorbaum jorbaum commented Feb 24, 2026

Description

Adjusts test scripts just like cloudfoundry/loggregator-agent-release#717 :

  • reuse ginkgo instead of recompiling every time, same as we are already doing with golangci-lint
  • cleaner check for binary removing three lines of code ;)

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

Testing performed?

  • Unit tests
  • Integration tests
  • Acceptance tests

Checklist:

  • This PR is being made against the main branch, or relevant version branch
  • I have made corresponding changes to the documentation
  • I have added testing for my changes

@jorbaum jorbaum force-pushed the minor-test-script-improvements branch from 3d31aa8 to c4be7b8 Compare March 2, 2026 08:40
@github-project-automation github-project-automation bot moved this from Inbox to Pending Merge | Prioritized in Application Runtime Platform Working Group Mar 2, 2026
@chombium chombium merged commit 524e67a into cloudfoundry:main Mar 2, 2026
5 checks passed
@github-project-automation github-project-automation bot moved this from Pending Merge | Prioritized to Done in Application Runtime Platform Working Group Mar 2, 2026
@jorbaum jorbaum deleted the minor-test-script-improvements branch March 3, 2026 15:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Development

Successfully merging this pull request may close these issues.

2 participants