Introduce an ACL for blocking on tcp layer#882
Open
hoffmaen wants to merge 4 commits intocloudfoundry:masterfrom
Open
Introduce an ACL for blocking on tcp layer#882hoffmaen wants to merge 4 commits intocloudfoundry:masterfrom
hoffmaen wants to merge 4 commits intocloudfoundry:masterfrom
Conversation
…cp_blacklist_cidrs to align with existing blacklist property & highlight difference
a18e
previously approved these changes
Mar 5, 2026
Contributor
a18e
left a comment
There was a problem hiding this comment.
Preliminary approval to trigger CI-run
a18e
approved these changes
Mar 5, 2026
Contributor
a18e
left a comment
There was a problem hiding this comment.
Preliminary approval to trigger CI-run No2.
maxmoehl
requested changes
Mar 5, 2026
Member
There was a problem hiding this comment.
Please use inclusive language for any new files / properties.
mv tcp_blacklist_cidrs.txt.erb tcp_blocklist_cidrs.txt.erb
Contributor
Author
There was a problem hiding this comment.
Or just revert the changes related to the filename at all. Suffixing the filename for the exact purpose makes more sense to me than a prefix.
Member
There was a problem hiding this comment.
This is a new file, not sure what you mean by reverting.
Member
There was a problem hiding this comment.
Ah, I don't care about the ordering of the terms in the filename.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
TCP-Level CIDR Blocking
Introduces a new property
ha_proxy.cidr_blocklist_tcpthat enables blocking client connections at the TCP layer, before TLS negotiation occurs.Implementation
ha_proxy.cidr_blocklist_tcp(optional array of CIDRs or base64-encoded gzipped string)/var/vcap/jobs/haproxy/config/blocklist_cidrs_tcp.txtConnection Flow for Blocked Clients
For HTTPS connections:
Client Hello)TCP FIN)This approach blocks clients before the expensive TLS handshake completes, improving performance and reducing resource consumption.
Limitations