Move StenoIO into Steno namespace as Steno::LoggerIO#4905
Merged
philippthun merged 1 commit intomainfrom Mar 5, 2026
Merged
Conversation
- Add Steno::LoggerIO: IO adapter wrapping Steno::Logger, forwarding write/puts to the logger at a configured log level - Add tests for Steno::LoggerIO - Remove StenoIO and its spec - Update Steno::Logger: broaden callstack filter from logger.rb only to all frames within lib/steno/, so records logged via Steno::LoggerIO are attributed to the correct caller - Update PumaRunner to use Steno::LoggerIO instead of StenoIO - Update lib/steno/README.md: document changes as modification #8
jochenehret
approved these changes
Mar 4, 2026
johha
approved these changes
Mar 5, 2026
ari-wg-gitbot
added a commit
to cloudfoundry/capi-release
that referenced
this pull request
Mar 5, 2026
Changes in cloud_controller_ng:
- Move StenoIO into Steno namespace as Steno::LoggerIO
PR: cloudfoundry/cloud_controller_ng#4905
Author: Philipp Thun <philipp.thun@sap.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Steno::LoggerIO: IO adapter wrappingSteno::Logger, forwardingwrite/putsto the logger at a configured log levelSteno::LoggerIOStenoIOand its specSteno::Logger: broaden callstack filter fromlogger.rbonly to all frames withinlib/steno/, so records logged viaSteno::LoggerIOare attributed to the correct callerPumaRunnerto useSteno::LoggerIOinstead ofStenoIOlib/steno/README.md: document changes as modification #8I have reviewed the contributing guide
I have viewed, signed, and submitted the Contributor License Agreement
I have made this pull request to the
mainbranchI have run all the unit tests using
bundle exec rakeI have run CF Acceptance Tests