Open
Conversation
johha
requested changes
Mar 4, 2026
| @@ -0,0 +1,17 @@ | |||
| # frozen_string_literal: true | |||
|
|
|||
| require_relative '../membrane_spec_helper' | |||
Contributor
There was a problem hiding this comment.
require 'membrane_spec_helper' does not work?
Contributor
Author
There was a problem hiding this comment.
No. The file is at spec/unit/lib/membrane/membrane_spec_helper.rb, which is not in the root of any load path directory. Ruby would need the full path like: require 'unit/lib/membrane/membrane_spec_helper'.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Inline archived membrane gem (last update in 2014).
A short explanation of the proposed change:
This change vendors (inlines) the membrane gem directly into the Cloud Controller repository under lib/membrane and removes the external gem dependency from the Gemfile.
A lightweight shim (lib/membrane.rb) ensures that existing require "membrane" statements continue to work without modification.
An explanation of the use cases your change solves
Removes dependency on an archived upstream repository:
The upstream cloudfoundry/membrane repository is archived and no longer maintained. Inlining eliminates reliance on an external, inactive dependency.
I have reviewed the contributing guide
I have viewed, signed, and submitted the Contributor License Agreement
I have made this pull request to the
mainbranchI have run all the unit tests using
bundle exec rakeI have run CF Acceptance Tests