boring-sys: Support static MSVC runtime#475
Merged
kornelski merged 1 commit intocloudflare:masterfrom Feb 13, 2026
Merged
Conversation
kornelski
approved these changes
Feb 12, 2026
kornelski
requested changes
Feb 12, 2026
boring-sys/build/config.rs
Outdated
| let unix = env::var("CARGO_CFG_UNIX").is_ok(); | ||
|
|
||
| let target_features = env::var("CARGO_CFG_TARGET_FEATURE") | ||
| .unwrap() |
Contributor
Author
There was a problem hiding this comment.
Boo to Cargo for not being consistent :-P Thanks.
jrose-signal
force-pushed
the
msvc-crt-static
branch
from
c5631d9 to
15a4934
Compare
kornelski
approved these changes
Feb 12, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adjustment to c299b14 to support
+crt-staticbuilds.(I don't consider myself a Windows expert; perhaps there's a better way to deal with the original issue. But this should be a strict improvement.)