You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.
This PR includes no changesets
When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types
Good call. From my tests, if you set just the parent menu to be modal, it works correctly:
Screencast.From.2026-01-29.19-55-41.mp4
However, there's some weirdness if you set modal: true on submenus - essentially, when moving the pointer over the trigger, the submenu gets constantly opened and closed. Modal submenus don't really seem like a valid use case, but still something to keep in mind:
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Addresses: #1722, chakra-ui/ark#2874
📝 Description
Adds support for modal behavior for
menu.⛳️ Current behavior (updates)
Menudoesn't support modality.🚀 New behavior
The
modalproperty can be set totrueformenu, meaning that it will:💣 Is this a breaking change (Yes/No):
No, the property is set to
falseby default, mirroring the behavior before the change.📝 Additional Information
The change is largely based on how modality is implemented in the
popover.