Open
Conversation
Tested with Python3.8.1
__cmp__ is not respected in Python 3, therefore a TypeError is raised in L215 in read_layers.py when it is attempted to sort the layers. This was fixed by renaming the __cmp__ method to __lt__.
We now use python:3.8.1-buster as baseimage. Without the gobject dependency we can use the latest python version, without running into trouble to not find the gobject bindings for that version. This also allows us, to use the latest version of pymupdf, as the only available wheel for buster default python 3.7.3 was 1.16.6. Now: 1.16.11
cfra
requested changes
Feb 28, 2020
Owner
cfra
left a comment
cfra
left a comment
There was a problem hiding this comment.
Thank you very much for this contribution towards cleaning up the requirements. 🙂
I have tested out this branch and discovered a few shortcomings with it which need to be fixed before it can go in:
- to ensure fonts remain readable, PDFs need to be rendered at the scale applicable for each tile,
just rendering the PDF once and resizing it for other zoom levels is unfortunately not an option - the new renderer doesn't seem to take inverted rendering and scaling/translation into account, at least some test layers which make use of these features yielded highly different results in the new renderer compared to the old renderer
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I removed the gobject dependency. I feel like this removes a lot of pain, as PyMuPDF is self-contained, and we now only have dependencies that are installable via pip.
Now the latest version of Python is used in the Dockerfile (3.8.1-buster).