Skip to content

ENT-12619: Suppress even more known-benign patterns in run_and_print_on_failure #2120

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
larsewi wants to merge 1 commit into
base: master
Choose a base branch
from
Draft

ENT-12619: Suppress even more known-benign patterns in run_and_print_on_failure #2120

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions build-scripts/functions
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -755,10 +755,10 @@ run_and_print_on_failure() {
regex='([Ww]arning:|[Ee]rror:)'
if grep_q -E "$regex" "$temp_output_file"; then
# Known-benign patterns that are not actionable and should be suppressed:
# - automake subdir-objects: forward-compatibility notice, harmless
# - automake subdirectory source file warnings and subdir-objects notice
# - libtool install warnings: normal when using DESTDIR
# shellcheck disable=SC3043
local benign='subdir-objects|libtool: warning: remember to run|libtool: warning:.*has not been installed|libtool: install:'
local benign='is in a subdirectory|subdir-objects|libtool: warning: remember to run|libtool: warning:.*has not been installed|libtool: install:'
# shellcheck disable=SC3043
local filtered
filtered=$(grep_c 2 -E "$regex" "$temp_output_file" | grep -v -E "$benign") || true
Expand Down