Apple link without cocoapods #351
Open
+519
−141
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kraenhansen
added
Apple 🍎
kraenhansen
force-pushed
the
kh/apple-link-without-cocoapods
branch
from
06b03e4 to
7a4eacc
Compare
kraenhansen
force-pushed
the
kh/apple-link-without-cocoapods
branch
from
fc32743 to
6dc2cfb
Compare
Collaborator
Author
|
Tests on MacOS passing on this PR is currently blocked by #353. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #262 and #213 by modifying the Xcode project after it has been generated by CocoaPods.
Merging this PR will:
patch-xcode-projectcommand to the host CLI: When called, it will modify the main Xcode app target to include a build phase which calls into the CLI withlink --appleargs.patch-xcode-projectcommand. Since users can run this commend themselves or we could drive it from a SPM project, I don't consider this a dependency on CocoaPods as such.bundle, based on environment variables provided by Xcode.
Because the frameworks are no longer explicitly referenced by targets we also don't have the issue of the dynamic libraries being loaded at startup time. Which means faster boot times and less concern about the order of operations as they'll be loaded when required by the app.