fix(#278): header status label inflates natural width with long status strings#279
Merged
cachebag merged 1 commit intocachebag:masterfrom Mar 16, 2026
Merged
fix(#278): header status label inflates natural width with long status strings#279cachebag merged 1 commit intocachebag:masterfrom
cachebag merged 1 commit intocachebag:masterfrom
Conversation
cachebag
requested changes
Mar 14, 2026
Owner
cachebag
left a comment
cachebag
left a comment
There was a problem hiding this comment.
Thanks for this! Could you clean up your commit history? We don't usually merge in PRs with Merge commits in their history.
cachebag
added
bug
Contributor
Author
|
I rebased and force-pushed. The merge commit was removed; history is now linear |
Contributor
Author
|
The failing check is due to the workflow trying to force-push from a fork PR |
Owner
Yeah, this is an issue with a workflow I've been working on to auto-update nix hashes. All good. Thank you for the contribution! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#278
Motivation
The header status label was inflating natural width with long strings, making compositor width behavior look ignored.
Description
This PR applies a surgical change in
nmrs-gui/src/ui/mod.rs:pango::EllipsizeModestatus.set_xalign(0.0)status.set_ellipsize(EllipsizeMode::End)status.set_max_width_chars(36)No changes were made to
networks.rs,wired_devices.rs, CSS, Stack/homogeneity, wrapping, or hard size requests/clamps.Testing
cargo fmt --all✅cargo test -p nmrs --all-features✅cargo test -p nmrs-guiglib-2.0.pcnot found viapkg-config).AI disclosure
Per
CONTRIBUTING.md, AI assistance was used to implement this small change and draft the PR description. I reviewed the diff and outputs before submission.