Remove anyhow from the WIT lexer#2461
Merged
alexcrichton merged 2 commits intobytecodealliance:mainfrom Mar 11, 2026
Merged
Conversation
alexcrichton
approved these changes
Mar 11, 2026
| impl core::error::Error for Error {} | ||
|
|
||
| impl Error { | ||
| pub fn position(&self) -> u32 { |
Member
There was a problem hiding this comment.
Could you add some docs to this method as well to indicate what the return value is? (e.g. a byte-offset from the start of the file)
Contributor
Author
There was a problem hiding this comment.
Done. These are byte offsets but they're global to the source map (which holds many files), not just to the file itself.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
lex:Error-ControlCodepoint,DeprecatedCodepoint,ForbiddenCodepointanyhowfrom the lexer API and implementation, by usingcore::result::Resultinstead ofanyhow::Result. This way the consumer of the lexer can extract granular error information without having to parse the error message.lex::Error::position()Part of #2460