IVS-678 - BUG: reused filename leads to failure to process#272
Open
rw-bsi wants to merge 1 commit intodevelopmentfrom
Open
IVS-678 - BUG: reused filename leads to failure to process#272rw-bsi wants to merge 1 commit intodevelopmentfrom
rw-bsi wants to merge 1 commit intodevelopmentfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Solved this by always using the alternative filename returned by
get_alternative_name()The default Django behaviour is to use this only when a physical filesystem collision occurs.
eg. user uploads file named
file1.ifcBefore this change:
file1.ifcfile1_dj134s4.ifc(random suffix of 7 chars)After this change:
file1_dj134s4.ifc(random suffix of 7 chars)file1_W31fr56.ifc(another random suffix of 7 chars)