IVS-132 - Replace download file with delete file#271
Open
rw-bsi wants to merge 2 commits intodevelopmentfrom
Open
IVS-132 - Replace download file with delete file#271rw-bsi wants to merge 2 commits intodevelopmentfrom
rw-bsi wants to merge 2 commits intodevelopmentfrom
Conversation
Ghesselink
approved these changes
Feb 18, 2026
Contributor
Ghesselink
left a comment
There was a problem hiding this comment.
Looks good & runs well locally.
I'd say add a functionality to give users a warning when they delete a file? So when they accidentally click it. Should be very quick.
Smth like (untested)
1. Inline delete button — [line 450-453]
// Current:
onClick={ (evt) => {
evt.stopPropagation();
setDeleted(row.id);
}}
// Add confirm:
onClick={ (evt) => {
evt.stopPropagation();
if (window.confirm('Are you sure you want to delete this IFC file?'))
setDeleted(row.id);
}}
2. Toolbar bulk delete — [line 336-338]
// Current:
function onDelete() {
setDeleted(selected.join(','))
}
// Add confirm:
function onDelete() {
if (window.confirm(`Delete ${selected.length} selected file(s)?`))
setDeleted(selected.join(','))
}
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Preview:
