Remove extraneous references to value in error messages#442
Remove extraneous references to value in error messages#442
Conversation
|
The latest Buf updates on your PR. Results from workflow Buf CI / buf (pull_request).
|
|
I agree that this results in a more natural error message. However, that won't be the case when the message is shown next to an input field in a form. You wouldn't include the field path in the error message, and the error message needs to stand on it's own. This works for |
I do not think there is a single instance of this in actual protovalidate usage. When this happens, we can adjust the error message accordingly. Otherwise, this is a QOL improvement for every other protovalidate user - can you get this merged? |
Whenever you get a validation error, it reads like this:
The "value" messaging is weird to me. It feels much more natural to have:
I would even argue for:
But that's a step too far for this simple PR.