Open
Conversation
🧪 Network TestsTo run network tests for this PR, use: gh workflow run network-tests.yml -f pr_number=998Available test options:
Test types: Results will be posted as workflow runs in the Actions tab. |
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## master #998 +/- ##
==========================================
+ Coverage 54.32% 54.57% +0.25%
==========================================
Files 403 414 +11
Lines 67754 68898 +1144
Branches 67754 68898 +1144
==========================================
+ Hits 36809 37604 +795
- Misses 29123 29393 +270
- Partials 1822 1901 +79 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Mododo
force-pushed
the
feature/consensus/cert-depth
branch
5 times, most recently
from
7a0e364 to
a9fe0cc
Compare
Mododo
force-pushed
the
feature/consensus/cert-depth
branch
from
b43a262 to
1fc6da5
Compare
Mododo
changed the title
Mododo
force-pushed
the
feature/consensus/cert-depth
branch
from
1fc6da5 to
28da0a1
Compare
evidences certify the point and `commit_history_depth` rounds of its dependencies
also fix `PeerId` in tl scheme
* separate status for commit attributes * store `has_proof` flag when it's known * less alloc in `set_status()`
* separate valid and invalid point statuses * make commit an attribute of cert * `committable` view of dag point
change leader every 3 rounds instead of 4
* contiguity check for new wave len * support unrecoverable gaps
Mododo
force-pushed
the
feature/consensus/cert-depth
branch
3 times, most recently
from
d1d0035 to
af6c94e
Compare
* validate local point during store * don't store final status for local point * separate error for bad evidence signs
* separate terminal ill-formed reasons * don't store first_resolved flag * fix history keeps final-ill-formed and first-valid statuses * don't repeat fix history with the same TKA
Mododo
force-pushed
the
feature/consensus/cert-depth
branch
from
af6c94e to
e8510d2
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request Checklist
NODE CONFIGURATION MODEL CHANGES
None
BLOCKCHAIN CONFIGURATION MODEL CHANGES
None
COMPATIBILITY
Affected features:
SPECIAL DEPLOYMENT ACTIONS
Apply new mempool genesis in GlobalConfig
TESTS
Unit Tests
Added behavioral unit tests
Network Tests
No coverage
Manual Tests
transfers-30k
Notes/Additional Comments:
Requires prior merge of #1016