Change Binary Download Distribution

[amaanbs]

No description provided.

[Copilot]

Pull Request Overview

This PR replaces the hardcoded binary download URL with a dynamic endpoint fetched from an API, adds an authentication key, and implements a retry/fallback mechanism on download failures.

• Added key to LocalBinary constructor and propagated it in Local.java
• Introduced fetchSourceUrl() to retrieve download endpoints and wired it into downloadBinary()
• Wrapped download logic in downloadAndVerifyBinary() with fallback and retry handling

Reviewed Changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 5 comments.

File	Description
src/main/java/com/browserstack/local/LocalBinary.java	Added key field; implemented downloadAndVerifyBinary(), fetchSourceUrl(), and updated download logic to use dynamic sourceUrl
src/main/java/com/browserstack/local/Local.java	Updated LocalBinary instantiation to pass the key from options

Comments suppressed due to low confidence (4)

src/main/java/com/browserstack/local/LocalBinary.java:53

• String comparison with != checks reference equality, not content. Use !path.isEmpty() or !"".equals(path) to test for an empty string.

if (path != "") {

src/main/java/com/browserstack/local/LocalBinary.java:31

• Use the primitive boolean instead of the wrapper Boolean for fallbackEnabled to avoid unnecessary boxing and potential null values.

private Boolean fallbackEnabled = false;

src/main/java/com/browserstack/local/Local.java:58

• The constructor now requires a key. Validate that options.get("key") is present and non-null, and provide a clear error if it's missing.

lb = new LocalBinary(options.get("binarypath"), options.get("key"));

src/main/java/com/browserstack/local/LocalBinary.java:196

• The new fetchSourceUrl retry and fallback logic is complex and isn’t covered by existing tests. Add unit tests to verify both success and failure paths.

private void fetchSourceUrl() throws LocalException {