fix: use real parameter names in method detail pane#107
Open
abanchev wants to merge 3 commits intobobbylight:masterfrom
Open
fix: use real parameter names in method detail pane#107abanchev wants to merge 3 commits intobobbylight:masterfrom
abanchev wants to merge 3 commits intobobbylight:masterfrom
Conversation
appendParamDescriptors() was hardcoding generic names (param0, param1) instead of reading actual parameter names from class file debug info via getParameterName(). Now falls back to paramN only when debug info is not available.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
appendParamDescriptors()inMethodInfowas hardcoding generic names (param0,param1, ...) instead of reading actual parameter names from class file debug info viagetParameterName()paramNonly when debug info is absentBefore / After
float random(float param0, float param1)float random(float min, float max)Test plan