Open
Conversation
MicahMaphet
reviewed
Nov 8, 2025
leolambo
reviewed
Dec 15, 2025
| * Override signTx to require vault access | ||
| */ | ||
| public async signTx(params: any): Promise<any> { | ||
| return this.withVaultAccess(params.passphrase, super.signTx.bind(this), params); |
Contributor
There was a problem hiding this comment.
this one is interesting withVaultAccess unlocks using the passphrase. but the passphrase still needs to be sent via params?
Contributor
Author
There was a problem hiding this comment.
Good catch. Updated.
leolambo
reviewed
Jan 2, 2026
| if (!this.publicKey) throw new Error('Vault not initialized (missing public key)'); | ||
|
|
||
| const promptText = opts.prompt ?? 'Passphrase: '; | ||
| const maxBytes = Math.min(Math.max(opts.maxBytes ?? 256, 8), 4096); |
Contributor
There was a problem hiding this comment.
RSA-2048 with OAEP padding and SHA-256 can encrypt a maximum of 190 bytes of data in a single operation. publicEncrypt on line 340 will throw for passphrases > 190 bytes. consider using 190 instead of 4096
| return total > 0; | ||
| } | ||
|
|
||
| public secureHeapAllocationCheck(): boolean { |
Contributor
There was a problem hiding this comment.
seems like dead code? also the base alloc >= current alloc is contradicting currentAllocation >= this.secureHeapBaseAllocation found on ln 70
Collaborator
|
@MichaelAJay You have unsigned commits in this PR |
MichaelAJay
force-pushed
the
bitcore-vault
branch
2 times, most recently
from
1397391 to
5d5cb7e
Compare
MichaelAJay
force-pushed
the
bitcore-vault
branch
from
5d5cb7e to
f38cda8
Compare
kajoseph
reviewed
Jan 22, 2026
MichaelAJay
force-pushed
the
bitcore-vault
branch
from
61ece36 to
44684d9
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.