-
Notifications
You must be signed in to change notification settings - Fork 88
Add -p short flag for pretty command #228
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
The -p short flag was conflicting with other options (proxy, password, path), causing CLI parsing errors and failing tests. Changed the short flag for --pretty to -P to avoid conflicts while keeping it intuitive. This restores test passes for all CLI flag positions and maintains backward compatibility.
Pull Request Test Coverage Report for Build 20858395002Details
💛 - Coveralls |
tvpeter
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @AmosOO7,
Thank you for working on this. However, your suggestion of using an uppercase "P" does not align with the short naming convention used throughout the codebase. It would be more suitable to use a different letter, as seen in some instances in the code.
As an alternative, I would suggest using h for "human-readable form". If you can think of a better option, please feel free to update it, and I'll review it again.
Thank you!
|
Thank you for taking a look at the @tvpeter, I don't think |
|
Will this still be relevant after #234? |
Description
This PR adds a short
-Pflag as an alias for the existing--prettyoption to make the command easier and faster to use.This closes #226
Notes to the reviewers
The new
-Pflag behaves exactly the same as--pretty.No existing behavior is changed — this only introduces an additional alias.
Changelog notice
Added
-Pas a shorthand flag for theprettycommand.Checklists
All Submissions:
cargo fmtandcargo clippy