Open
Conversation
…oes the ThreadPool class write anything to console output. Also I altered a Makefile so that it also makes an .so file and puts it in bin directory
Author
|
I would suggest you alter all your code so that it meets all requirements of the C++ google style guide, the naming in the project is terrible: Also I suggest you write unit tests for the project :) Do a lot of stress testing. |
Author
|
Here is a python script that takes .cpp and .h files as an argument and spits out all the style errors that dont corespont to google style guide: https://google-styleguide.googlecode.com/svn/trunk/cpplint/cpplint.py you can make a build.sh script that runs this before compilation. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I made a VERBOSE pre-processor symbol to Global.h that controls if ThreadPool class writes anything to console output.
Makefile now builds a shared object too and puts it in bin directory.