You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This comment from the PR suggests you may have mistaken user.dir for user.home:
If the env variable is not present the test data will be assumed in a bc-test-data folder in your user root dir.
user.dir is the directory Java was launched from, not your user root dir. The search process first looks there and then back up along the path. The intended simple config is to checkout bc-test-data as a sibling of bc-java; note that the same test data is also looked for by other BC projects by the same logic (e.g. bc-csharp and the FIPS and LTS versions) - it was previously included in all those projects separately.
I think adding a comment to this effect in the Building section is fine; I'm less keen on introducing an environment variable.
I'm fine with doing only the change in the README. But that should really be done since I felt into exactly that pitfall. I will update the PR based on your feedback
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Suggestion to make the solution for #2246 more clear and add a way to place test data on a different folder (by using an ENV).