OpenPGPCertificate: Fix getCertification(date) accidentally returning…#2217
Open
vanitasvitae wants to merge 2 commits intobcgit:mainfrom
Open
OpenPGPCertificate: Fix getCertification(date) accidentally returning…#2217vanitasvitae wants to merge 2 commits intobcgit:mainfrom
vanitasvitae wants to merge 2 commits intobcgit:mainfrom
Conversation
…on to self-signatures
Contributor
Author
|
79058d9 fixes a bug where the OpenPGPMessageProcessor would accidentally inspect a third-party signature when verifying whether a signing key is valid. |
Contributor
Author
|
Do you have insights as to when this can be merged? Currently the underlying bug prevents the proper use of certificates with recent third-party signatures from being used for basic operations like signing and encryption, which is a major breakage both in BC and PGPainless :/ |
This was referenced Feb 4, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
… non-self-sig
This was originally brought up as a bug report in PGPainless: pgpainless/pgpainless#495
Here, when PGPainless attempts to deduce the key expiration time of a certificate containing a third-party certification over the primary user-id, with the third-party sig being newer than the self-sig, BC would accidentally return the 3rd-party sig for evaluation. This evaluation failed, due to the signature being created by an external key, however, due to the bug, PGPainless would refuse to encrypt to the key.
With this patch, methods that are supposed to return self-signatures now filter out non-self-signatures.