feat: allow pip to get default from toolchain config#3298
Draft
rickeylev wants to merge 1 commit intobazel-contrib:mainfrom
Draft
feat: allow pip to get default from toolchain config#3298rickeylev wants to merge 1 commit intobazel-contrib:mainfrom
rickeylev wants to merge 1 commit intobazel-contrib:mainfrom
Conversation
rickeylev
force-pushed
the
feat.pip.version.from.default
branch
2 times, most recently
from
7245224 to
499fca6
Compare
along the way: * exposes python version via files in local toolchain
rickeylev
force-pushed
the
feat.pip.version.from.default
branch
from
499fca6 to
1782f70
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This allows pip.parse to have python_version unspecified, getting the value from the
default configured by the python extension. This allows the pip integration code to
automatically match a dynamically computed default (i.e. one from python_version_env
or python_version_file). With the two in sync, this then allows pip to generate
appropriate code that relies on knowing the python version.
DO NOT MERGE, todo:
Work towards #3293