chore: remove mock writeStatusAndHeaders shadowing in writer tests#657
Merged
sebsto merged 1 commit intoawslabs:mainfrom Mar 4, 2026
Merged
Conversation
sebsto
approved these changes
Mar 2, 2026
Collaborator
sebsto
left a comment
sebsto
left a comment
There was a problem hiding this comment.
Thank you for catching this
Collaborator
|
This PR has a draft status - I will wait for your green light to merge. |
Collaborator
Author
|
done, updated. |
manojmahapatra
force-pushed
the
test/fix-writers-mock-shadowing
branch
from
b3fc31f to
4e05f10
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue #
N/A
Description of changes
LambdaResponseStreamWriter+HeadersTests.swiftimplemented their ownwriteStatusAndHeaders(...).New/existing dependencies impact assessment, if applicable
Conventional Commits
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.