Conversation
b43f217 to
2a687b5
Compare
2a687b5 to
327c739
Compare
Author
|
Hello, this PR addresses many long-standing issues. I would greatly appreciate it if you could take a look! |
saligrama
added a commit
to formalco/session-manager-plugin
that referenced
this pull request
Jan 29, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
closes #93
closes #83
closes #76
closes #57
as mentioned in the above issues,
VERSIONis fixed at1.2.0.0causing the session-manager-plugin to exit after 30 seconds. (ref: #83 (comment)) This behavior makes the plugin unusable when using it as a library from other tools.Additionally, the README does not mention the need to edit the VERSION, which results in non-functional binaries when built from the source code. In fact, a non-working version is bundled with Alpine.
Description of changes:
This PR resolves the issue by specifying the version.
I have confirmed that binaries built with this version work as expected.
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.