Skip to content

Conversation

@dagnir
Copy link
Contributor

@dagnir dagnir commented Feb 11, 2026

Motivation and Context

Ensure we integ test with Apache 5.

Modifications

Changes:

  • Add an additional job in Integ testing CI workflow to run the integration tests with Apache 5
  • Update the patch so it applies cleanly after some removals
  • Add a -v to the apply command to make apply issues easy to see in failed CodeBuild builds
  • Update the policy statement used by one of the DDB integ tests because Apache 5.6 included new usage of setOption.

Testing

Screenshots (if appropriate)

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)

Checklist

  • I have read the CONTRIBUTING document
  • Local run of mvn install succeeds
  • My code follows the code style of this project
  • My change requires a change to the Javadoc documentation
  • I have updated the Javadoc documentation accordingly
  • I have added tests to cover my changes
  • All new and existing tests passed
  • I have added a changelog entry. Adding a new entry must be accomplished by running the scripts/new-change script and following the instructions. Commit the new file created by the script in .changes/next-release with your changes.
  • My change is to implement 1.11 parity feature and I have updated LaunchChangelog

License

  • I confirm that this pull request can be released under the Apache 2 license

Changes:
 - Add an additional job in Integ testing CI workflow to run the
   integration tests with Apache 5
 - Update the patch so it applies cleanly after some removals
 - Add a -v to the apply command to make apply issues easy to see in
   failed CodeBuild builds
 - Update the policy statement used by one of the DDB integ tests
   because Apache 5.6 included new usage of setOption.
@dagnir dagnir force-pushed the dongie/integ-test-apache5-update branch from ce98153 to 12a9cc5 Compare February 11, 2026 01:06
permission "java.lang.RuntimePermission" "accessDeclaredMembers";
permission "javax.net.ssl.SSLPermission" "setDefaultSSLContext";
permission "java.net.SocketPermission" "*", "connect,resolve";
permission "jdk.net.NetworkPermission" "*", "setOption.";
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Apache5 uses this new API. https://github.com/apache/httpcomponents-client/blob/d8d09ed89605cbd41d759fab2626bba561602ed0/httpclient5/src/main/java/org/apache/hc/client5/http/impl/io/DefaultHttpClientConnectionOperator.java#L338-L340

This didn't get exercised previously because we were integ testing with a very old version of JDK8 that didn't have these APIs

@dagnir dagnir changed the title Update 5.x testing patch Apache5 Integ Testing job Feb 11, 2026
@sonarqubecloud
Copy link

Quality Gate Failed Quality Gate failed

Failed conditions
2 Security Hotspots
C Security Rating on New Code (required ≥ A)

See analysis details on SonarQube Cloud

Catch issues before they fail your Quality Gate with our IDE extension SonarQube for IDE

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant