Conversation
pull-request-size
bot
added
the
size/XL
boring-cyborg
bot
added
dependencies
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## develop #7910 +/- ##
========================================
Coverage 96.72% 96.72%
========================================
Files 275 275
Lines 13214 13214
Branches 1006 1006
========================================
Hits 12781 12781
Misses 325 325
Partials 108 108 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
|
||
| if self._has_source_changed(): | ||
| subprocess.run(self.build_command, shell=True, check=True) | ||
| # Build wheel first, then install with platform constraints |
There was a problem hiding this comment.
Just for my own curiosity, why does these new commands need to be added?
There was a problem hiding this comment.
Honestly, I think this bunch of commands is overkill for managing dependencies. We're not concerned with cold start and things like that; we just want to ensure everything works as expected after any code change, regardless of whether we install libraries with debug symbols, binaries, or not. So, I think I'll refactor all these commands and use the PythonFunction constructor from the CDK, which takes care of all that.
|
| pip install --upgrade pip pre-commit uv | ||
| uv sync --all-extras |
There was a problem hiding this comment.
I like the move to uv.
Maybe somthing like this?
pip install --upgrade uv
uv sync --all-extras
and putting pre-commit (maybe pre-commit-uv) to extras? I think, you do not need to upgrade pip anymore after installing uv. what do you think?
There was a problem hiding this comment.
Yes, you're right! I'm focusing now on resolving the issue with our end-to-end tests that are overengenireeing dependencies install, and I'll take a look on this after that.
Thanks for the tip, @tonnico.
3 participants
Issue number: closes #5624
Summary
This PR migrates our pipelines from Poetry to uv.
Poetry examples in
examples/build_recipes/poetry/kept for users who still use it.Changes
User experience
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.
Disclaimer: We value your time and bandwidth. As such, any pull requests created on non-triaged issues might not be successful.