Skip to content

perf(core): precompute cookie store for request handling #111

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
halvaradop merged 1 commit into from
Mar 3, 2026
Merged

perf(core): precompute cookie store for request handling #111

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
19 changes: 6 additions & 13 deletions packages/core/src/index.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,18 +33,17 @@ const createInternalConfig = (authConfig?: AuthConfig): RouterConfig => {
const useProxyHeaders =
trustedProxyHeadersEnv === undefined ? (authConfig?.trustedProxyHeaders ?? false) : getEnvBoolean("TRUSTED_PROXY_HEADERS")
const logger = createProxyLogger(authConfig)
const cookiePrefix = authConfig?.cookies?.prefix
const cookieOverrides = authConfig?.cookies?.overrides ?? {}
const secureCookieStore = createCookieStore(true, cookiePrefix, cookieOverrides, logger)
const standardCookieStore = createCookieStore(false, cookiePrefix, cookieOverrides, logger)

return {
basePath: authConfig?.basePath ?? "/auth",
onError: createErrorHandler(logger),
context: {
oauth: createBuiltInOAuthProviders(authConfig?.oauth),
cookies: createCookieStore(
useProxyHeaders,
authConfig?.cookies?.prefix,
authConfig?.cookies?.overrides ?? {},
logger
),
cookies: standardCookieStore,
jose: createJoseInstance(authConfig?.secret),
secret: authConfig?.secret,
basePath: authConfig?.basePath ?? "/auth",
Expand All @@ -56,13 +55,7 @@ const createInternalConfig = (authConfig?: AuthConfig): RouterConfig => {
use: [
(ctx) => {
const useSecure = useSecureCookies(ctx.request, ctx.context.trustedProxyHeaders)
const cookies = createCookieStore(
useSecure,
authConfig?.cookies?.prefix,
authConfig?.cookies?.overrides ?? {},
logger
)
ctx.context.cookies = cookies
ctx.context.cookies = useSecure ? secureCookieStore : standardCookieStore
return ctx
},
],
Expand Down
Loading