Draft
Conversation
…s (LINTEST-425)
This commit resolves the issue where Okta Push Groups fails with stale
externalId errors due to orphaned SSO group mappings in Keycloak.
Changes:
- Add diagnostic script to identify orphaned SSO group mappings
- Add cleanup functionality to remove orphaned mappings
- Enhance SSO client with better validation and logging
- Add new error codes for SSO mapping issues
- Create comprehensive documentation for troubleshooting
- Add support guide for resolving orphaned mapping issues
- Add unit tests for diagnostic utility
The diagnostic script can:
1. Identify orphaned mappings (where group ID no longer exists)
2. Clean up orphaned mappings (interactive or automated)
3. List all SSO group mappings for a provider
4. Filter diagnostics by specific group name
Usage:
python -m pyatlan.samples.sso.diagnose_orphaned_group_mappings \
--mode diagnose --sso-alias okta
Fixes: LINTEST-425
Author
|
Cursor Agent can help with this pull request. Just |
- Remove unused Set import from diagnose_orphaned_group_mappings.py - Fix trailing whitespace in all modified files - Add None check for mapping.id before deletion to satisfy mypy - Format code to pass ruff format and ruff check
- Break long lines in docstrings and help text - Split long conditional statements across multiple lines - Format function signatures to be within line length limits
Remove trailing whitespace from empty lines in diagnostic script docstring
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
✨ Description
This PR resolves LINTEST-425 by addressing the issue of Okta Push Groups failing due to stale
externalIdreferences and orphaned SSO group mappings.It introduces a diagnostic and cleanup utility to identify and remove these orphaned mappings, enhances the SSO client with improved validation and logging, and provides comprehensive documentation for users and support teams.
Jira link: LINTEST-425
🧩 Type of change
Select all that apply:
✅ How has this been tested? (e.g. screenshots, logs, workflow links)
The changes have been tested with comprehensive unit tests (
tests/unit/test_sso_diagnostic.py) covering:📋 Checklist