Skip to content

Comments

tests/channels/pjsip/message: add out-of-dialog Contact stripping test#124

Open
AlexisHadj wants to merge 1 commit intoasterisk:masterfrom
AlexisHadj:testRFC3428
Open

tests/channels/pjsip/message: add out-of-dialog Contact stripping test#124
AlexisHadj wants to merge 1 commit intoasterisk:masterfrom
AlexisHadj:testRFC3428

Conversation

@AlexisHadj
Copy link

@AlexisHadj AlexisHadj commented Feb 12, 2026

This new test verifies that Asterisk correctly strips the Contact header from outbound MESSAGE requests, as required by RFC 3428.

1-Added SIPp scenarios to send and receive MESSAGEs with inverse
validation on the Contact header.
2-Added Asterisk configuration (pjsip.conf, extensions.conf) to
support the test.
3-Registered the new test in the pjsip message test suite.

This new test verifies that Asterisk correctly strips the Contact
header from outbound MESSAGE requests, as required by RFC 3428.

1-Added SIPp scenarios to send and receive MESSAGEs with inverse
  validation on the Contact header.
2-Added Asterisk configuration (pjsip.conf, extensions.conf) to
  support the test.
3-Registered the new test in the pjsip message test suite.
@AlexisHadj
Copy link
Author

AlexisHadj commented Feb 12, 2026

Note: This test is associated with the change in Pull Request #1729 therefore should be merged after Pull Request #1729 . That is the reason master-gates check fails with ".....Regexp matched but should not....""

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Checklist Complete

@github-actions
Copy link

Workflow PRCheck failed
master-gates: FAILED TEST: channels/pjsip/message/message_out_dialog

@gtjoseph
Copy link
Member

@AlexisHadj You can link the asterisk PR and testsuite PR together...

https://docs.asterisk.org/Development/Policies-and-Procedures/Code-Contribution/#test-against-a-testsuite-pr

You can do that when you add your cherry-pick-to lines...

https://docs.asterisk.org/Development/Policies-and-Procedures/Code-Contribution/#cherry-picking

@AlexisHadj AlexisHadj changed the title tests/channels/pjsip/message: Add out-of-dialog Contact stripping test tests/channels/pjsip/message: add out-of-dialog Contact stripping test Feb 17, 2026
@AlexisHadj
Copy link
Author

AlexisHadj commented Feb 17, 2026

cherry-pick-to: 20
cherry-pick-to: 22
cherry-pick-to: 23
asterisk-test-pr: 1729

@github-actions
Copy link

Workflow PRCheck completed successfully

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants