Definition for known format types.#230
Open
mklemarczyk wants to merge 1 commit intoarduino-libraries:masterfrom
Open
Definition for known format types.#230mklemarczyk wants to merge 1 commit intoarduino-libraries:masterfrom
mklemarczyk wants to merge 1 commit intoarduino-libraries:masterfrom
Conversation
|
IMHO would it look better if these were snake_case rather than CamelCase, and made to resemble the C99 standard: BleUint8 -> ble_uint8_t etc. But probably irrelevant for this. |
Contributor
Author
|
It is a constant for a value, you can not declare those types in the code. Will it not create a confusion with the value types form C99 ? The current naming follows the other constants like BLEEncryption, BLERead. I would like to ask if there is a concern for merge that PR that I can address? It is waiting quite a long time. |
Contributor
Author
|
@facchinm You do not want this change? There are several PRs waiting, and no comment or merged. |
Contributor
Author
|
Bump, any answer on the integration ? I wonder why it takes so long... |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
To simplify usage of the ArduinoBLE, I added the definitions for format types.
In the future I would like to add also known services and characteristics uuid codes.
I check with the Arduino compiler that the definitions are included in result binary only if they are used by the code. So no extra space will be taken, Please review and tell what do you think about the idea. I find it more useful than searching the internet for proper values.
I has been forced to use char type, as Description constructor does not accept the
uint8_ttype as input for value.BLEDescriptor::BLEDescriptor(const char* uuid, const uint8_t value[], int valueSize)BLEDescriptor::BLEDescriptor(const char* uuid, const char* value)