fix 'add --help' typo, refactor ora to dynamic import, move colors.js#20
Open
ixc7 wants to merge 1 commit intoapostrophecms:mainfrom
Open
fix 'add --help' typo, refactor ora to dynamic import, move colors.js#20ixc7 wants to merge 1 commit intoapostrophecms:mainfrom
ixc7 wants to merge 1 commit intoapostrophecms:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes 'add --help' typo, refactors ora to dynamic import statement, moves colors.js
What are the specific steps to test this change?
For example:
What kind of change does this PR introduce?
(Check at least one)
Make sure the PR fulfills these requirements:
If adding a new feature without an already open issue, it's best to open a feature request issue first and wait for approval before working on it.
Other information:
Moves "require('colors')" statement from bin/apostrophe to lib/util.js where it is used.
Fixes typo for "./bin/apostrophe add --help"
see https://asciinema.org/a/469939
Changes ora to dynamic import() statement
see sindresorhus/ora#189