Conversation
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| } | ||
|
|
||
| except (configparser.NoSectionError) as err: | ||
| print("Error in configuration file. Check that file exists first: %s" % err) |
Check notice
Code scanning / CodeQL
Use of a print statement at module level Note
| <input type="radio" id="submission_type" name="submission_type" value="validate"> Validate | ||
| <br> | ||
| <input type="radio" id="submission_type" name="submission_type" value="load"> Load |
There was a problem hiding this comment.
HTML requires unique IDs
<input type="radio" id="submission_type_validate" name="submission_type" value="validate"> Validate <br> <input type="radio" id="submission_type_load" name="submission_type" value="load"> Load
There was a problem hiding this comment.
Does it need both id and name?
There was a problem hiding this comment.
Ah, I see, id does need to be unique. But then the actual question is, do we need everything tagged with an id? Are we referring to elements by id anywhere?
There was a problem hiding this comment.
Yeah I got confused when I was rushing, its the name element that gets searched for by submission_type = request.POST.get("submission_type", "") in the views file, not the id.
tofu-rocketry
force-pushed
the
GT1180-apel-loading-validator
branch
from
49c2787 to
ba20fb0
Compare
- has radio buttons to specifiy whether record should be validated or loaded
- adds new load method - creates instance of apel loader - makes use of a blackhole mariadb database, which doesn't store data
- also fixes validator bug which would prevent v0.4 records from getting a formatted output
tofu-rocketry
force-pushed
the
GT1180-apel-loading-validator
branch
from
ba20fb0 to
1c9df0e
Compare
tofu-rocketry
left a comment
tofu-rocketry
left a comment
There was a problem hiding this comment.
We could do with some documentation in monitoring/docs that explains how to set up the database (and blockhole engine) for this manually.
See also discussion started by @garaimanoj
|
One more point - we can't have Line 2 in 1b15ffa |
3 participants
host where this is running: http://host-172-16-103-131.nubes.stfc.ac.uk/validator/
Resolves GT-1228
Resolves GT-1328