Skip to content

Fix /debugging/config/dump may leak sensitive information if there are second level properties in the configuration.#13726

Open
wankai123 wants to merge 3 commits intoapache:masterfrom
wankai123:config-mask
Open

Fix /debugging/config/dump may leak sensitive information if there are second level properties in the configuration.#13726
wankai123 wants to merge 3 commits intoapache:masterfrom
wankai123:config-mask

Conversation

@wankai123
Copy link
Member

  • If this pull request closes/resolves/fixes an existing issue, replace the issue number. Closes #.
  • Update the CHANGES log.

…are second level properties in the configuration.
@wankai123 wankai123 added this to the 10.4.0 milestone Mar 5, 2026
@wankai123 wankai123 requested review from Copilot and wu-sheng March 5, 2026 06:13
@wankai123 wankai123 added bug Something isn't working and you are sure it's a bug! backend OAP backend related. labels Mar 5, 2026
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR fixes a security issue where the /debugging/config/dump endpoint could leak sensitive information when configuration properties contain nested (second-level) Properties objects. Previously, only top-level property values were iterated and masked; nested Properties values were dumped as raw Properties.toString() output without masking.

Changes:

  • Added handling for nested Properties values in dumpBootingConfigurations, flattening them into dot-separated keys and applying masking individually.
  • Extracted the masking logic into a reusable maskConfigValue method with proper Javadoc.
  • Updated the changelog to document the fix.

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.

File Description
oap-server/server-core/src/main/java/org/apache/skywalking/oap/server/core/status/ServerStatusService.java Handles nested Properties in config dump, extracts masking into a helper method
docs/en/changes/changes.md Adds changelog entry for the fix

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

You can also share your feedback on Copilot code review. Take the survey.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backend OAP backend related. bug Something isn't working and you are sure it's a bug!

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants