Fix /debugging/config/dump may leak sensitive information if there are second level properties in the configuration.#13726
Open
wankai123 wants to merge 3 commits intoapache:masterfrom
Open
Fix /debugging/config/dump may leak sensitive information if there are second level properties in the configuration.#13726wankai123 wants to merge 3 commits intoapache:masterfrom
/debugging/config/dump may leak sensitive information if there are second level properties in the configuration.#13726wankai123 wants to merge 3 commits intoapache:masterfrom
Conversation
…are second level properties in the configuration.
There was a problem hiding this comment.
Pull request overview
This PR fixes a security issue where the /debugging/config/dump endpoint could leak sensitive information when configuration properties contain nested (second-level) Properties objects. Previously, only top-level property values were iterated and masked; nested Properties values were dumped as raw Properties.toString() output without masking.
Changes:
- Added handling for nested
Propertiesvalues indumpBootingConfigurations, flattening them into dot-separated keys and applying masking individually. - Extracted the masking logic into a reusable
maskConfigValuemethod with proper Javadoc. - Updated the changelog to document the fix.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
oap-server/server-core/src/main/java/org/apache/skywalking/oap/server/core/status/ServerStatusService.java |
Handles nested Properties in config dump, extracts masking into a helper method |
docs/en/changes/changes.md |
Adds changelog entry for the fix |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
You can also share your feedback on Copilot code review. Take the survey.
...ver-core/src/main/java/org/apache/skywalking/oap/server/core/status/ServerStatusService.java
Show resolved
Hide resolved
...ver-core/src/main/java/org/apache/skywalking/oap/server/core/status/ServerStatusService.java
Show resolved
Hide resolved
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
CHANGESlog.