Fix clang tidy errors not detected as well as the errors#544
Merged
BewareMyPower merged 8 commits intoapache:mainfrom Mar 4, 2026
Merged
Fix clang tidy errors not detected as well as the errors#544BewareMyPower merged 8 commits intoapache:mainfrom
BewareMyPower merged 8 commits intoapache:mainfrom
Conversation
BewareMyPower
changed the title
shibd
approved these changes
Mar 4, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In
build-support/run_clang_tidy.sh,set +ewill swallow the error of this script, so some clang tidy errors won't be detected by CI.This patch fixes the script by adding
set -ebefore running the tidy check, as well as fixing the code that violates the clang tidy rule. Additionally, fix the vcpkg cache that does not work if the workflow fails.